Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mapValues instead of map in SchemaKStream.select #411

Merged
merged 1 commit into from
Oct 27, 2017
Merged

use mapValues instead of map in SchemaKStream.select #411

merged 1 commit into from
Oct 27, 2017

Conversation

dguy
Copy link
Contributor

@dguy dguy commented Oct 25, 2017 •
edited
Loading

As we are not changing the key during select, there is no point in using map. Using mapValues will avoid a re-partitioning event if the resulting stream is joined.

hjafarpour
hjafarpour approved these changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dguy dguy merged commit 676f946 into confluentinc:4.0.x Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjafarpour hjafarpour hjafarpour approved these changes

@apurvam apurvam Awaiting requested review from apurvam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dguy @hjafarpour